Mrc 6647 ci docker by absternator · Pull Request #11 · mrc-ide/mint-v2

absternator · 2025-10-08T09:23:52Z

The following PR sets up CI + Docker. It also adds a docker-compose file that can be used for testing.

Testing:
run FRONTEND_REF=mrc-6647-ci-docker docker compose up and head to 127.0.0.1:3000 and ensure everything works as intended

…actor Docker setup and remove unused routes

…ocalhost binding

…ide/mint-v2 into mrc-6647-ci-docker

…s and testing

… to README fix: update mint-frontend service configuration in docker-compose.yml

…ADME with environment variable examples

- Added a new script "test:unit:coverage" to run unit tests with coverage using Vitest. - Updated package.json to include "@vitest/coverage-v8" for coverage reporting.

…overage

… initialization

codecov · 2025-10-08T11:33:21Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

…CI settings

Copilot

Pull Request Overview

This PR establishes a comprehensive CI/CD pipeline and Docker containerization setup for the Mint v2 application. The changes enable automated testing, building, and deployment through GitHub Actions workflows while providing Docker compose support for local development and testing.

Key changes include:

CI/CD pipeline setup with GitHub Actions for testing, building, and pushing Docker images
Docker containerization with multi-stage Dockerfile and docker-compose configuration
SvelteKit adapter migration from auto to node for containerized deployment

Reviewed Changes

Copilot reviewed 21 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
svelte.config.js	Switched from adapter-auto to adapter-node for Docker deployment
Dockerfile	Multi-stage Node.js build with production optimization
compose.yml	Docker compose setup with Redis, frontend, and API services
.github/workflows/*	CI workflows for testing, E2E tests, and Docker image building
src/lib/url.ts	Changed from static to dynamic environment variables
src/lib/server/redis.ts	Updated Redis configuration for containerized environments
src/lib/server/session.ts	Modified cookie sameSite policy for cross-origin compatibility
scripts/*	Updated dependency management scripts for new container names
src/tests/*	Fixed test cases to match current application structure
package.json	Added Node adapter and coverage testing dependencies

Copilot · 2025-10-08T13:18:48Z

src/lib/server/session.ts

 		httpOnly: true,
 		secure: true,
-		sameSite: 'lax',
+		sameSite: 'none',


Setting sameSite to 'none' requires the 'secure' flag to be true and can expose the application to CSRF attacks. Consider using 'lax' or 'strict' instead, or ensure this change is necessary for your specific cross-origin requirements.

Suggested change

sameSite: 'none',

sameSite: 'lax',

Copilot · 2025-10-08T13:18:48Z

README.md

+1. **Start services**:
+
+   ```sh
+   docker-compose up -d


The documentation references 'docker-compose.yml' but the actual file is named 'compose.yml'. The commands should use 'docker compose' (without hyphen) for the newer Docker Compose V2 syntax.

Copilot · 2025-10-08T13:18:49Z

README.md

+3. **Stop services**:
+
+   ```sh
+   docker-compose down


The documentation references 'docker-compose.yml' but the actual file is named 'compose.yml'. The commands should use 'docker compose' (without hyphen) for the newer Docker Compose V2 syntax.

…ywright configuration from separate file

M-Kusumgar

got a couple of small comment! but looks good

M-Kusumgar · 2025-10-09T11:39:25Z

.github/workflows/build-push.yml

+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v3


why do we need this? i remember its been on the ci for packit i think, but i dont think we actually needed this right

cool have removed.. i just added because it was in the docker action docs

M-Kusumgar · 2025-10-09T12:39:16Z

.github/workflows/test.yml

+      matrix:
+        node-version: [22.x]


do we need matrix if we are only testing against one version? or do we plan on testing against different versions? i dont think people usually test against different versions of npm

M-Kusumgar · 2025-10-09T12:45:59Z

README.md

+   ```sh
+   docker-compose up
+   ```


should we also include docker compose up --build to rebuild changes?

not anymore because im using the image from ghcr and not building locally

…ide/mint-v2 into mrc-6647-ci-docker

absternator and others added 20 commits October 7, 2025 10:50

feat: update dependencies and configuration for Redis and Svelte; ref…

5f36112

…actor Docker setup and remove unused routes

secure cookie true and mapping 127.0.0.1 ports

45ec0a9

feat: update Docker Compose to expose Redis and Mintr ports without l…

c0f6c4f

…ocalhost binding

refactor: remove debug logging for user ID and new user state creation

62ad3eb

Merge branch 'mrc-6774-strategise-display' of https://github.com/mrc-…

f962a53

…ide/mint-v2 into mrc-6647-ci-docker

fix: update Redis volume mapping and standardize API reference variable

73b1503

feat: add GitHub Actions workflows for building, pushing Docker image…

60d8cae

…s and testing

fix: reorder steps in test workflow for clarity and consistency

7e4709d

docs: add Docker usage instructions and environment variable examples…

49ba987

… to README fix: update mint-frontend service configuration in docker-compose.yml

fix: standardize formatting in GitHub Actions workflows and update RE…

771a2d7

…ADME with environment variable examples

Add unit test coverage command and update dependencies

19b181e

- Added a new script "test:unit:coverage" to run unit tests with coverage using Vitest. - Updated package.json to include "@vitest/coverage-v8" for coverage reporting.

feat: add Playwright test workflow and update .gitignore to include c…

fb03763

…overage

fix: standardize variable naming in scripts and improve workflow clarity

e758ef3

test: enhance test cases for +page.server and +page.svelte components

1f87db2

fix: standardize quotes in GitHub Actions workflow configuration

7282899

fix: standardize quote styles in GitHub Actions workflow

10f4fda

fix: handle undefined REDIS_URL in Redis connection initialization

f1e5979

fix: set default Redis URL to 'redis://localhost:6379' for connection…

57f4051

… initialization

fix: standardize quote styles in GitHub Actions workflow

fb72f72

fix: standardize quote styles in GitHub Actions workflow

65fa133

absternator added 2 commits October 8, 2025 14:10

fix: update Playwright configuration to include parallel testing and …

673b0ea

…CI settings

fix: update SameSite attribute for userId cookie to 'lax'

ae1d34b

absternator requested review from M-Kusumgar and Copilot October 8, 2025 13:17

Copilot AI reviewed Oct 8, 2025

View reviewed changes

absternator added 3 commits October 8, 2025 14:19

fix: add end-to-end testing workflow to GitHub Actions and remove Pla…

7f69d81

…ywright configuration from separate file

fix: update README to clarify application readiness before accessing

3e8c929

fix: remove trailing space in docker-compose command in README

e182685

M-Kusumgar reviewed Oct 9, 2025

View reviewed changes

absternator mentioned this pull request Oct 9, 2025

Mrc-6649 MINT-V2 deploy mrc-ide/mint-deploy#2

Merged

fix: standardize quotes in workflow files and update Node.js setup

34e110c

absternator requested a review from M-Kusumgar October 9, 2025 14:10

M-Kusumgar approved these changes Oct 9, 2025

View reviewed changes

Merge branch 'mrc-6774-strategise-display' of https://github.com/mrc-…

6ad185d

…ide/mint-v2 into mrc-6647-ci-docker

Base automatically changed from mrc-6774-strategise-display to main October 10, 2025 10:05

absternator merged commit cfab19c into main Oct 10, 2025
5 checks passed

absternator deleted the mrc-6647-ci-docker branch October 10, 2025 10:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mrc 6647 ci docker#11

Mrc 6647 ci docker#11
absternator merged 27 commits intomainfrom
mrc-6647-ci-docker

absternator commented Oct 8, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 8, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 8, 2025

Uh oh!

Copilot AI Oct 8, 2025

Uh oh!

Copilot AI Oct 8, 2025

Uh oh!

M-Kusumgar left a comment

Uh oh!

M-Kusumgar Oct 9, 2025

Uh oh!

absternator Oct 9, 2025

Uh oh!

M-Kusumgar Oct 9, 2025

Uh oh!

M-Kusumgar Oct 9, 2025

Uh oh!

absternator Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

absternator commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 8, 2025

Welcome to Codecov 🎉

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

M-Kusumgar left a comment

Choose a reason for hiding this comment

Uh oh!

M-Kusumgar Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

absternator Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

M-Kusumgar Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

M-Kusumgar Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

absternator Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

absternator commented Oct 8, 2025 •

edited

Loading