Skip to content

feat: emit full query to posthog #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: eval-pr-805-target-1758284673051
Choose a base branch
from
Open

feat: emit full query to posthog #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions backend/airweave/analytics/search_analytics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def build_search_properties(
Dictionary of analytics properties
"""
properties = {
"query": query, # Full query text for PostHog history
Copy link

@cubic-dev-ai cubic-dev-ai bot Sep 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a potential sensitive data leak. The raw search query is being added to the PostHog analytics event, but the project's analytics guidelines in backend/airweave/analytics/README.md explicitly forbid including sensitive data in event properties. Search queries may contain PII or other sensitive information.

Prompt for AI agents 
Address the following comment on backend/airweave/analytics/search_analytics.py at line 35:

<comment>This change introduces a potential sensitive data leak. The raw search query is being added to the PostHog analytics event, but the project&#39;s analytics guidelines in `backend/airweave/analytics/README.md` explicitly forbid including sensitive data in event properties. Search queries may contain PII or other sensitive information.</comment>

<file context>
@@ -32,6 +32,7 @@ def build_search_properties(
         Dictionary of analytics properties
     &quot;&quot;&quot;
     properties = {
+        &quot;query&quot;: query,  # Full query text for PostHog history
         &quot;query_length&quot;: len(query),
         &quot;collection_slug&quot;: collection_slug,
</file context>

[internal] Confidence score: 10/10

[internal] Posted by: System Design Agent

Fix with Cubic

Copy link
Author

@cubic-dev-local cubic-dev-local bot Sep 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change sends the full search query text to PostHog, which violates the project's own analytics guidelines. The analytics/README.md states, 'Sensitive data should not be included in event properties.' Search queries can contain PII or other confidential information, making this a potential privacy and compliance issue.

Prompt for AI agents 
Address the following comment on backend/airweave/analytics/search_analytics.py at line 35:

<comment>This change sends the full search query text to PostHog, which violates the project&#39;s own analytics guidelines. The `analytics/README.md` states, &#39;Sensitive data should not be included in event properties.&#39; Search queries can contain PII or other confidential information, making this a potential privacy and compliance issue.</comment>

<file context>
@@ -32,6 +32,7 @@ def build_search_properties(
         Dictionary of analytics properties
     &quot;&quot;&quot;
     properties = {
+        &quot;query&quot;: query,  # Full query text for PostHog history
         &quot;query_length&quot;: len(query),
         &quot;collection_slug&quot;: collection_slug,
</file context>

[internal] Confidence score: 10/10

[internal] Posted by: System Design Agent

Fix with Cubic

Copy link
Author

@cubic-dev-local cubic-dev-local bot Sep 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new query property isn’t documented in the Search Event Properties section; update docs to reflect this property for consistency.

DEV MODE: This violation would have been filtered out by screening filters. Failing filters: commentPurpose, documentationImpact.

    DEV MODE: This violation would have been filtered out by GPT-5.

Reasoning:
• GPT-5: Only a docs mismatch; low severity with no functional impact. Not worth reporting compared to privacy issues.

Prompt for AI agents 
Address the following comment on backend/airweave/analytics/search_analytics.py at line 35:

<comment>The new `query` property isn’t documented in the Search Event Properties section; update docs to reflect this property for consistency.

*DEV MODE: This violation would have been filtered out by screening filters. Failing filters: commentPurpose, documentationImpact.*

        DEV MODE: This violation would have been filtered out by GPT-5.
Reasoning:
• **GPT-5**: Only a docs mismatch; low severity with no functional impact. Not worth reporting compared to privacy issues.</comment>

<file context>
@@ -32,6 +32,7 @@ def build_search_properties(
         Dictionary of analytics properties
     &quot;&quot;&quot;
     properties = {
+        &quot;query&quot;: query,  # Full query text for PostHog history
         &quot;query_length&quot;: len(query),
         &quot;collection_slug&quot;: collection_slug,
</file context>

[internal] Confidence score: 7/10

[internal] Posted by: General AI Review Agent

Fix with Cubic

"query_length": len(query),
"collection_slug": collection_slug,
"duration_ms": duration_ms,
Expand Down Expand Up @@ -71,6 +72,7 @@ def build_search_error_properties(
Dictionary of analytics properties
"""
return {
"query": query, # Full query text for PostHog history
"query_length": len(query) if query else 0,
"collection_slug": collection_slug,
"duration_ms": duration_ms,
Expand Down