Skip to content

fix: Fix modular_headers iOS build #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Fix modular_headers iOS build #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d40f80
chore: Remove `modular_headers` from Podfile
mrousavy Aug 29, 2025
0a34c3a
Set `s.static_framework = true`
mrousavy Aug 29, 2025
0bc60b0
fix: Use `CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES`
mrousavy Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions example/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ target 'MmkvExample' do
:app_path => "#{Pod::Config.instance.installation_root}/.."
)

pod 'MMKVCore', :modular_headers => true

post_install do |installer|
# https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L197-L202
react_native_post_install(
Expand Down
4 changes: 4 additions & 0 deletions packages/react-native-mmkv/NitroMmkv.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ Pod::Spec.new do |s|
s.libraries = 'z', 'c++'
s.dependency 'MMKVCore', '>= 2.2.3'

s.pod_target_xcconfig = {
"CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES" => "YES"
}

load 'nitrogen/generated/ios/NitroMmkv+autolinking.rb'
add_nitrogen_files(s)

Expand Down
Loading