fix: Reset Harness timeout on test progress - #4127
Draft
mrousavy wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@react-native-harness/bridge@1.4.0-rc.1so pending RPC timeouts can be refreshed by matching progress events.test-startedandtest-finishedevents from the same test file as progress forrunTests.Why
Harness currently applies
bridgeTimeoutonce to the entirerunTestsRPC. A long test file such asvisioncamera.controller.harness.tscan therefore be killed after 120 seconds even while individual tests continue completing.The patched timeout behaves as an inactivity deadline instead. Active files remain alive, while a genuinely stalled test still fails after a full timeout interval without progress. Unrelated bridge events cannot keep a stalled file alive.
Validation
distsmoke testbun install --frozen-lockfilegit diff --checkThe full Android suite was not run locally because this worktree does not contain a built debug APK.