Skip to content

Add hypothesis-powered tests - #469

Closed
hexagonrecursion wants to merge 28 commits into
msgpack:mainfrom
hexagonrecursion:hypothesis
Closed

hexagonrecursion wants to merge 28 commits into
msgpack:mainfrom
hexagonrecursion:hypothesis

Conversation

@hexagonrecursion

Copy link
Copy Markdown
Contributor

Error:
E   hypothesis.errors.FailedHealthCheck: Data generation is extremely
slow: Only produced 9 valid examples in 1.16 seconds
(0 invalid ones and 0 exceeded maximum size).
Try decreasing size of the data you're generating
(with e.g.max_size or max_leaves parameters).
E   hypothesis.errors.FailedHealthCheck: Data generation is extremely
slow: Only produced 7 valid examples in 1.01 seconds (0 invalid ones and
 1 exceeded maximum size). Try decreasing size of the data you're
 generating (with e.g.max_size or max_leaves parameters).
E   See https://hypothesis.readthedocs.io/en/latest/healthchecks.html
for more information about this. If you want to disable just this
health check, add HealthCheck.too_slow to the suppress_health_check
settings for this test.
E   hypothesis.errors.FailedHealthCheck: Data generation is extremely
slow: Only produced 7 valid examples in 1.01 seconds (0 invalid ones and
 1 exceeded maximum size). Try decreasing size of the data you're
 generating (with e.g.max_size or max_leaves parameters).
E   See https://hypothesis.readthedocs.io/en/latest/healthchecks.html
for more information about this. If you want to disable just this
health check, add HealthCheck.too_slow to the suppress_health_check
settings for this test.
@hexagonrecursion

Copy link
Copy Markdown
Contributor Author

This is wrong. It should not be that hard to add a new dependency. Why are you repeating the same information in so many places? You have tox.ini. Use it.

@hexagonrecursion
hexagonrecursion marked this pull request as draft March 1, 2021 10:27
@methane

methane commented Mar 1, 2021

Copy link
Copy Markdown
Member

I do not use tox.

@hexagonrecursion

Copy link
Copy Markdown
Contributor Author

I have finally hit genuine test failures. I'll look into them later.

>       assert repr(obj) == repr(got)

E       assert '{b\'"b\': No...641537: None}' == '{2.000000001...\'"b\': None}'

E         - {2.0000000011641537: None, b'"b': None}

E         + {b'"b': None, 2.0000000011641537: None}

@methane

methane commented Mar 1, 2021

Copy link
Copy Markdown
Member

I have finally hit genuine test failures. I'll look into them later.

Dicts in old Pythons don't preserve order.

@methane

methane commented Mar 1, 2021

Copy link
Copy Markdown
Member

I'm not interested in fuzzing packer. I'm interested in Unpacker because it can be attack surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants