Skip to content

dts: msm8916-samsung: add grandmaxltezc #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dts: msm8916-samsung: add grandmaxltezc #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions lk2nd/device/dts/msm8916/msm8916-samsung.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,4 +841,23 @@
};
};
};

grandmaxltezc {
Copy link
Contributor

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To put the nodes in order, move this after node grandmaxlteub.

model = "Samsung Galaxy Grand Max (SM-G7200)";
Copy link
Contributor

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise Jul 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this after comments, /* rev 4 */, https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/device/dts/msm8916/msm8916-samsung.dts#L717

Update: rev 8 -> 4

Copy link
Contributor

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise Jul 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still not sorted in revision order. There are 11 revisions, and 4 < 11.

Update: revision 8 -> 4

compatible = "samsung,grandmaxltechn", "samsung,grandmax";
lk2nd,match-bootloader = "G7200*";

lk2nd,dtb-files = "msm8916-samsung-grandmax";

qcom,msm-id = <QCOM_ID_MSM8916 0>;
qcom,board-id = <0xCE08FF01 8>;
Copy link
Contributor

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
qcom,board-id = <0xCE08FF01 8>;
qcom,board-id = <0xCE08FF01 4>;

The revision is probably not correct, so fastboot boot boot.img would not work.
Grand Max is known to be revision 4.

Ref: https://lxr.trvn.ru/linux-downstream/SM-G720AX/source/arch/arm/boot/dts/samsung/msm8916/msm8916-sec-grandmax-r04.dts#L24


muic-reset {
compatible = "samsung,muic-reset";
i2c-reg = <0x14>;
i2c-sda-gpios = <&tlmm 105 I2C_GPIO_FLAGS>;
i2c-scl-gpios = <&tlmm 106 I2C_GPIO_FLAGS>;
};
};

};