Skip to content

WIP: Moto G7 (river) Support #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP: Moto G7 (river) Support #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85d91dd
Initial commit
ElliotLurie Aug 19, 2025
8432e26
Actually build
ElliotLurie Aug 19, 2025
5e71172
Clean
ElliotLurie Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lk2nd/device/dts/msm8953/rules.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ ADTBS += \
$(LOCAL_DIR)/sdm450-xiaomi-rosy.dtb \
$(LOCAL_DIR)/sdm632-fairphone-fp3.dtb \
$(LOCAL_DIR)/sdm632-motorola-ocean.dtb \
$(LOCAL_DIR)/sdm632-motorola-river.dtb \
$(LOCAL_DIR)/sdm632-mtp.dtb \

QCDTBS += \
Expand Down
29 changes: 29 additions & 0 deletions lk2nd/device/dts/msm8953/sdm632-motorola-river.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// SPDX-License-Identifier: GPL-2.0-only
Copy link
Member

@TravMurav TravMurav Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// SPDX-License-Identifier: GPL-2.0-only
// SPDX-License-Identifier: BSD-3-Clause

if possible, we try to align to the modern Linux practice for dts.


/dts-v1/;

#include <skeleton64.dtsi>
#include <lk2nd.dtsi>
#include <motorola-carrier-channel-ids.dtsi>

/ {
model = "Qualcomm Technologies, Inc. SDM632 + PMI632 MTP S3";
Copy link
Member

@TravMurav TravMurav Oct 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which of the lines in / {} are actually required for the device to boot?

(edit: I now see the device didn't yet boot properly, we usually try to minimize the amount of stuff in / where possible, but that can be figured out later, when the device actually boots to lk2nd)

compatible = "qcom,sdm632-mtp", "qcom,sdm632", "qcom,mtp";
qcom,msm-id = <0x15d 0x00>;
Copy link
Contributor

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
qcom,msm-id = <0x15d 0x00>;
qcom,msm-id = <QCOM_ID_SDM632 0>;

qcom,msm-name = "SDM632";
qcom,pmic-id = <0x10016 0x25 0x00 0x00>;
qcom,board-id = <0x45 0xb1b0>, <0x45 0xa100>, <0x45 0xa200>, <0x145 0xa100>, <0x145 0xa200>;

__symbols__ {};
};

&lk2nd {
model = "Motorola G7 (River)";
compatible = "motorola,river";

lk2nd,dtb-files = "sdm632-motorola-river";

unit-info {
compatible = "motorola,unit-info";
};
};