WIP: Moto Z2 play (albus) Support #595
Conversation
|
How did you flash or boot lk2nd if USB doesn't work? |
|
USB is not working in lk2nd but it works in Android and fastboot mode. |
Co-authored-by: Raymond Hackley <[email protected]>
This is required for android and TWRP to boot on this device
| }; | ||
|
|
||
| &lk2nd { | ||
| lk2nd,dtb-files = "msm8953-albus-p0"; |
There was a problem hiding this comment.
Where are the dtb files if you need to load them?
There was a problem hiding this comment.
In the Android kernel qcdt image, apparently.
Without it, when I try to flash the boot.img using fastboot, this error appears in the log:
[11280] DTB Total entry: 7, DTB version: 2
[11280] ERROR: Unable to find suitable device tree for device (293/0x00010001/0x00010008/0)
[11290] ERROR: Getting device tree address failed
[11300] DTB offset is incorrect, kernel image does not have appended DTB.
Adding this to the device tree fixes the problem.
There was a problem hiding this comment.
the dtb names and board-ids came from this: https://pastebin.com/Mm8htFgP
There was a problem hiding this comment.
Maybe I gave the commit a bad name. In it, I'm just trying to separate each board, with a different board-id, into its own device tree, which prevents the issue in fastboot.
Most likely, the "lk2nd,dtb-files" entries are not strictly necessary. I compiled the code without them, and the "fastboot boot" command still worked in lk2nd.
There was a problem hiding this comment.
Nah this property is meant for booting mainline kernel instead of android downstream. It's pointless if these dtb files are nonexistent in mainline kernel.
There was a problem hiding this comment.
Ok, I hadn’t understood that very well. Since albus isn’t in the mainline kernel yet, I should remove that property from the seven DTS files, right?
There was a problem hiding this comment.
As already noted, dtb-files are useless outside of booting mainline, and, on top of that, having separate dtb and file hint would only be useful if those devices are meaningfully physically different. Otherwise this is useless, and if you only have a file for a board id, could as well put all board ids into the same file. -- see other motorola devices in this dir.
|
|
||
| QCDTBS += \ | ||
| $(LOCAL_DIR)/msm8953-motorola-potter.dtb \ | ||
| $(LOCAL_DIR)/msm8953-motorola-albus-p0.dtb \ |
There was a problem hiding this comment.
do you actually need /all/ of those device revisions in separate files?
| // Copyright (c) 2014, The Linux Foundation. All rights reserved. (FIXME) | ||
|
|
||
| #ifndef _PANEL_SMD_549_1080P_ALB_CMD_V0_H_ | ||
| #define _PANEL_SMD_549_1080P_ALB_CMD_V0_H_ |
There was a problem hiding this comment.
are you using lk1st or otherwise using this panel driver? if so, I'd expect you document the device as quirky in the dts and provide notes on how to enable the panel driver.
| }; | ||
|
|
||
| &lk2nd { | ||
| lk2nd,dtb-files = "msm8953-albus-p0"; |
There was a problem hiding this comment.
As already noted, dtb-files are useless outside of booting mainline, and, on top of that, having separate dtb and file hint would only be useful if those devices are meaningfully physically different. Otherwise this is useless, and if you only have a file for a board id, could as well put all board ids into the same file. -- see other motorola devices in this dir.
4 participants
lk2nd is starting, but usb doesn't work.I tested a new cable and with it lk2nd is working. It was a hardware issue. My bad.