Skip to content

Add support for Lenovo Tab 2 A10-30 #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add support for Lenovo Tab 2 A10-30 #603

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2fe8b8c
dts: msm8909: Added support for Lenovo Tab 2 A10-30
kucer0043 Oct 30, 2025
f11c1b8
dts: msm8909: Added support for Lenovo Tab 2 A10-30
kucer0043 Oct 30, 2025
b713866
Revert "dts: msm8909: Added support for Lenovo Tab 2 A10-30"
kucer0043 Oct 31, 2025
16899f5
Revert "dts: msm8909: Added support for Lenovo Tab 2 A10-30"
kucer0043 Oct 31, 2025
a4e0fbd
device tree moved to msm8909-1gb-qrd-skuc.dts
kucer0043 Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions lk2nd/device/dts/msm8909/msm8909-lenovo-achilles.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
// SPDX-License-Identifier: BSD-3-Clause

/dts-v1/;
#include <skeleton32.dtsi>
#include <lk2nd.dtsi>

/ {
qcom,msm-id = <0xf5 0x00>;
qcom,board-id = <0x1000b 0x08 0x11000b 0x08 0x21000b 0x08>;
Copy link
Contributor

@wonderfulShrineMaidenOfParadise wonderfulShrineMaidenOfParadise Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

	qcom,msm-id = <QCOM_ID_MSM8909 0>;
	qcom,board-id = <QCOM_BOARD_ID(QRD, 0x01, 0) 0x8>,
			<QCOM_BOARD_ID(QRD, 0x11, 0) 0x8>,
			<QCOM_BOARD_ID(QRD, 0x21, 0) 0x8>;

It's identical to msm8909-1gb-qrd-skuc and we can move this device to it. We cannot have 2 device trees with identical ids either way.

Copy link
Author

@kucer0043 kucer0043 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it.


};

&lk2nd {
model = "Lenovo Tab 2 A10-30 (Achilles)";
compatible = "lenovo,Achilles";

lk2nd,dtb-files = "msm8909-lenovo-achilles";
lk2nd,match-panel;

panel {
compatible = "lenovo,achilles", "lk2nd,panel";

qcom,mdss_dsi_nt35521s_xingyuan_wxga_video {
compatible = "lenovo,nt35521s-xingyuan";
};
};

gpio-keys {
compatible = "gpio-keys";
volume-up {
lk2nd,code = <KEY_VOLUMEUP>;
gpios = <&tlmm 90 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
};
};
};
1 change: 1 addition & 0 deletions lk2nd/device/dts/msm8909/rules.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ LOCAL_DIR := $(GET_LOCAL_DIR)
QCDTBS += \
$(LOCAL_DIR)/apq8009-1gb-qrd-skue.dtb \
$(LOCAL_DIR)/apq8009-lenovo-tb-x103f.dtb \
$(LOCAL_DIR)/msm8909-lenovo-achilles.dtb \
$(LOCAL_DIR)/msm8905-qrd-skub.dtb \
$(LOCAL_DIR)/msm8909-1gb-qrd-skuc.dtb \
$(LOCAL_DIR)/msm8909-1gb-qrd-skue.dtb \
Expand Down