chore: bump sv and sv-utils devdep and peer - #7
paoloricciuti wants to merge 2 commits into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Smart to write it like this Yes, it looks good to me like this. 👍 |
| @@ -0,0 +1,95 @@ | |||
| import assert from 'node:assert/strict' | |||
There was a problem hiding this comment.
Why *.mjs? Afaik, since the repo is ESM, all .js is treated as ESM.
| new URL('../.test-output/', import.meta.url), | ||
| ) | ||
| fs.mkdirSync(testDirectory, { recursive: true }) | ||
| process.env.MSW_VERSION = '3.0.0' |
There was a problem hiding this comment.
Is it safe to hard-code this?
| import assert from 'node:assert/strict' | ||
| import fs from 'node:fs' | ||
| import path from 'node:path' | ||
| import { test } from 'node:test' |
There was a problem hiding this comment.
Can we please use Vitest since the project already has it? I see node:test providing us no benefits here, only diverging the tooling.
|
Looks good! Thank you for opening this, @paoloricciuti. Let me know if it's safe to merge. |
|
Looks safe to merge...didn't do it because I'm not familiar with the publishing setup and didn't want to mess something 😅 |
|
Does this have to be published? Let me know, I'll adjust the conventional commit name for this PR then. |
Yup, the dependency is bundled. |
3 participants
We released
sv@1.0.1yesterday together with SvelteKit 3.This bumps the peerdep and the devdep. I've also
asked Astrato add a compatibility test for older versions just to be safe, but I'm not sure it's really necessary (cc @jycouet).