Remember UI pane positions for session #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en creating a new one of same kind.
… calling Window.dockWidgetArea in remove_xxx.
…ng one pane doesn't change the other's position.
|
Looks good to me. Merging. Many thanks @devdanzin 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add simple support for reopening the UI panes (inspector, plotter, repl, runner) in the same dock area (bottom, left, right) they were previously moved to, as discussed in #1122.
As can be seen below, a given pane's position isn't stable in each of these areas. As cannot be seen below (sorry!) both the debugger inspector and debugger runner remember the areas they belong to, and moving a debugger runner doesn't change normal runner's recorded area.
As of right now REPLs, plotters and non-debugger runners clobber the positions of equivalent panes in other modes.
The filesystem pane isn't currently movable, but can easily be added if we decide to change that.