More styling work #533
Merged
More styling work #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works as expected for QMessageBox but Mode/Admin have some odd behaviour Haven't started on other themes yet
|
Also included: Mode selector preselects the current mode reducing the chances of accidental switches |
|
Aha... so you've just missed beta.17, but should be able to make RC. :-) |
…wn/mu into base/more-styling-work
|
Hoped to get thing sent in by 4 but life got the better of me |
|
The images look good too... I'll get to this tomorrow (currently writing a blog post about beta.17 release announcement). |
|
Heh... I hoped to have beta 17 out last Wednesday... ;-) |
|
OK... took a quick look and merged it. Nice work! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has grown a bit
On macOS/Linux/Windows our scrollbars use a Qt fallback which looks interesting and is almost invisible in the contrast theme. Similarly masOS/Windows/Some Linux fallback to a grey on grey 9xish design.
So visually this PR styles the scrollbar & dialog buttons and adds some borders to text areas in the admin dialog
Some pictures!
Haven't included hover states here because reliably screenshotting them was an issue
Whole admin dialog for comparison
Codewise this sets the stylesheet globally instead of per window/widget. Don't have any metrics but in theory this should be more efficient as it avoids parsing the theme multiple times.
This reduces the need to pass the theme around all the time and ensures everything is themed (See unsaved work dialog)
Obviously a lot of this is up for discussion and #530 could help simplify many areas of theme handling