[test] Setup tests on all browsers #1592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Firefox connection timeouts look like vitest-dev/vitest#7377 |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
mj12albert
reviewed
Apr 24, 2025
| @@ -43,11 +43,16 @@ | |||
| "test:regressions:dev": "vite --config test/regressions/vite.config.mjs", | |||
| "test:regressions:run": "cross-env VITEST_ENV=chromium vitest --project regressions", | |||
| "test:regressions:server": "serve test/regressions -p 5173", | |||
| "test:jsdom": "cross-env NODE_ENV=test VITEST_ENV=jsdom vitest --project @base-ui-components/react --project docs", | |||
| "test:_unit": "cross-env NODE_ENV=test vitest --project @base-ui-components/react --project docs", | |||
There was a problem hiding this comment.
Is the underscore in test:_unit intentional?
There was a problem hiding this comment.
yes, to indicate it's a subtask, not meant to be used directly
mj12albert
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare npm scripts for running the test in each supported browser (Chromium, Firefox and WebKit) separately or in all at once.
I initially intended to run all browsers on CI, but they are quite unstable.