-
-
Notifications
You must be signed in to change notification settings - Fork 109
[Backdrops] Fix text selection & right-clicks #1702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@atomiks I've only updated the dismiss behavior for Dialog so it doesn't close on right click (matches Radix) Will leave the rest alone in this PR given the larger outside press issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need regular userSelect
for Android?
Also wonder if pointerEvents: undefined
(instead of conditional rendering for openReason === 'hover'
could be a problem
I tested Popover with a mouse and a phone and it seems ok, but |
|
Fixes #1705
Adding
WebkitUserSelect: 'none'
to the inlined styles prevents text selection on touchOnly main-button clicks on dialog backdrop should close it
I have followed (at least) the PR section of the contributing guide.