Skip to content

[code-infra] Remove babel alias and fix extensions #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 28, 2025

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Apr 28, 2025

File extensions were broken since #1662. I believe the alias is only there in core to serve the mocha tests. we should never alias in babel.

To do:

  • Add a test that captures this
  • Move to @mui/internal-babel-plugin-resolve-imports? Let's concentrate on this when unifying all package build pipelines across the company

Copy link

netlify bot commented Apr 28, 2025

Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit e37c35c
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/680f67357a8e38000817f5f0
😎 Deploy Preview https://deploy-preview-1789--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Janpot Janpot marked this pull request as ready for review April 28, 2025 11:38
@Janpot Janpot merged commit f1a4774 into mui:master Apr 28, 2025
22 checks passed
@michaldudak michaldudak added the scope: code-infra Specific to the code-infra product label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the code-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants