[popups] Refactor useDismiss to use an internal class instance
#3391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
component: menu
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
PR: out-of-date
|
|
||
| controller.useSetup(); | ||
|
|
||
| React.useEffect(() => { |
Member
There was a problem hiding this comment.
Nitpick, but here you can save one function allocation:
Suggested change
| React.useEffect(() => { | |
| React.useEffect(controller.disposeEffect); |
Where disposeEffect is:
public disposeEffect() {
return () => {
this.cancelDismissOnEndTimeout.clear();
this.clearInsideReactTreeTimeout.clear();
}
}
Contributor
There was a problem hiding this comment.
disposeEffect = ... for the bound this though. The useTimeout hook is a good model for class-based hooks (and it saves another allocation by using useOnMount instead of useEffect(..., [])). I've been thinking we might want to create a base class for class hooks to standardize and/or manage automatic resource cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.