[docs] Fix example snippets in props table #3422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
docs
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
LukasTy
reviewed
Dec 5, 2025
| <pre {...props} className="text-xs p-0 m-0" style={{ backgroundColor: undefined }} /> | ||
| </Accordion.Scrollable> | ||
| ); | ||
| return <pre {...props} className="text-xs p-0 m-0" style={{ backgroundColor: undefined }} />; |
Member
There was a problem hiding this comment.
I think we need to keep the Scrollable element here. 🤔
Longer pieces of type definition would become unreadable on narrow screens.
https://deploy-preview-3422--base-ui.netlify.app/react/components/combobox#ComboboxPositioner-alignOffset
vs
https://base-ui.com/react/components/combobox#ComboboxPositioner-alignOffset
Screen.Recording.2025-12-05.at.12.46.08.mov
mj12albert
force-pushed
the
docs/fix-props-table-example
branch
from
766fe3f to
7c8fac6
Compare
LukasTy
approved these changes
Dec 8, 2025
Member
LukasTy
left a comment
LukasTy
left a comment
There was a problem hiding this comment.
Looks great now. 👍
Just one nitpick. 😃
atomiks
pushed a commit
to atomiks/base-ui
that referenced
this pull request
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-3422--base-ui.netlify.app/react/components/select#SelectRoot-items
It broke in #2718