[combobox][autocomplete] Remove unsupported data-instant documentation - #5351
[combobox][autocomplete] Remove unsupported data-instant documentation#5351lyzno1 wants to merge 4 commits into
Conversation
commit: |
Bundle size
PerformanceTotal duration: 1,224.51 ms +57.46 ms(+4.9%) | Renders: 78 (+0) | Paint: 1,919.55 ms +95.39 ms(+5.2%)
14 tests within noise — details Metric alarms
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@atomiks is the #2 docs discovery in the PR review below a real gap? Is it intentional? Regarding #1, you can address it in this same PR @lyzno1. PR reviewDocs-only change, and the premise checks out: Docs (2)1. ℹ️
|
|
@aarongarciah Done — addressed |
|
@aarongarciah Since combobox is keyboard-interactive even for pointer users I think leaving it off makes sense, since iirc its purpose was to make keyboard interaction instant, with no animations (especially for Tooltip). We can leave it off until someone files an issue about it. |
|
@atomiks Can this PR be merged before the 1.7.0 release? |
Summary
data-instantentry from the Combobox popup data attribute metadataBoth
Combobox.PopupandAutocomplete.PopupshareComboboxPopup. Its runtime state and state attribute mapping do not implement an instant animation reason, so the documented attribute was never generated on the DOM.This documentation-only correction does not change runtime behavior.
Fixes #5350