Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Prepare libraries for first v7 alpha release #45132

Merged
merged 12 commits into from
Jan 29, 2025

Conversation

DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Jan 27, 2025

Important note for reviewers

Reviewing commit per commit will be much easier

Summary

Included in this PR

  • Update version tags to next
  • Change host to next.mui.com
  • Target specific versions of workspace dependencies
  • Target next version in examples
  • Add v6 to the docs' version dropdown
  • Remove some unnecessary #default-branch-switch comments
  • Add v7 to the docs' versions table

Not included in this PR

  • Any changes to Base or Joy related files

@DiegoAndai DiegoAndai added the core Infrastructure work going on behind the scenes label Jan 27, 2025
@DiegoAndai DiegoAndai self-assigned this Jan 27, 2025
@DiegoAndai DiegoAndai changed the title [core] Update libraries for first v7 alpha release (@next) [core] Prepare libraries for first v7 alpha release (@next) Jan 27, 2025
@DiegoAndai DiegoAndai changed the title [core] Prepare libraries for first v7 alpha release (@next) [core] Prepare libraries for first v7 alpha release Jan 27, 2025
@DiegoAndai
Copy link
Member Author

We're using #default-branch-switch to mark where changes are required, but with the new protocol, some of these changes happen on master branch and others on v6.x branch, so the comment becomes confusing. There are 4 types of changes that are encompassed under this tag:

  • Changes to the npm version tag (latest -> next) in master (This PR)
  • Changes to the host (mui.com -> next.mui.com) in master (This PR)
  • Changes to repository links (ttps://github.com/mui/material-ui/tree/master -> github.com/mui/material-ui/tree/v6.x) in v6.x (45133)
  • Changes to target branches for CI checks/builds (master -> v6.x) in v6.x (45133)

I propose splitting these into 4 different tags:

  • #npm-tag-reference
  • #host-reference
  • #repo-reference
  • #target-branch-reference

By splitting them, it will be easier to follow the branch split protocol and understand what each one refers to.

I used reference instead of switch as I think it's more descriptive and reads better: "Here's is a reference of the npm tag/host/repo/target branch"

Let me know if I should go forward with this change @mnajdova.

@DiegoAndai DiegoAndai requested review from Janpot and mnajdova January 27, 2025 18:52
@DiegoAndai DiegoAndai marked this pull request as ready for review January 27, 2025 18:52
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@DiegoAndai DiegoAndai merged commit 26c8644 into mui:master Jan 29, 2025
22 checks passed
@DiegoAndai DiegoAndai deleted the prepare-v7-alpha-release branch January 29, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants