[docs-infra] Move focus to the main content with the skip link - #48944
Open
lazerg wants to merge 1 commit into
Open
[docs-infra] Move focus to the main content with the skip link#48944lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48943
Activating "Skip to content" scrolled the page but left DOM focus where it was, so the next Tab went back through the announcement bar and the header.
MarkdownLinksregisters a document-level click handler that callspreventDefault()on every internal anchor and hands the URL toRouter.push, and the skip link goes through it as well, so the browser never runs its own fragment navigation.Opting the link out with
data-no-markdown-linkbrings that back, and#main-contentnow carriestabIndex={-1}so it can receive focus.Validation:
pnpm test:e2e-website:dev -g "skip link", which fails on master and passes herepnpm eslint,pnpm typescriptandpnpm prettier --checkon the touched files