fix(DashboardLayout): render NavigationItem.action as ListItem secondfix(DashboardLayout): render NavigationItem.action as ListItem's secondaryAction - #5135
Open
forurmah wants to merge 1 commit into
Conversation
Netlify deploy preview |
Author
|
Looks like the CI failures are unrelated to this change — the CircleCI logs show: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4747
When a
NavigationItemhas anaction(e.g. a button rendered in the expanded sidebar), it was rendered inside the clickableNavigationListItemButton, so pointer events on the action also triggered the parent nav item's click handler.This moves
item.actionout of the button and passes it viaListItem's built-insecondaryActionprop instead, following MUI's standard pattern for this composition — the action now renders as a sibling of the button rather than a nested clickable element, so clicks no longer propagate.