Skip to content

fix(DashboardLayout): render NavigationItem.action as ListItem secondfix(DashboardLayout): render NavigationItem.action as ListItem's secondaryAction - #5135

Open
forurmah wants to merge 1 commit into
mui:masterfrom
forurmah:fix/navigation-item-action-click-bubbling
Open

fix(DashboardLayout): render NavigationItem.action as ListItem secondfix(DashboardLayout): render NavigationItem.action as ListItem's secondaryAction#5135
forurmah wants to merge 1 commit into
mui:masterfrom
forurmah:fix/navigation-item-action-click-bubbling

Conversation

@forurmah

@forurmah forurmah commented Aug 6, 2026

Copy link
Copy Markdown

Fixes #4747

When a NavigationItem has an action (e.g. a button rendered in the expanded sidebar), it was rendered inside the clickable NavigationListItemButton, so pointer events on the action also triggered the parent nav item's click handler.

This moves item.action out of the button and passes it via ListItem's built-in secondaryAction prop instead, following MUI's standard pattern for this composition — the action now renders as a sibling of the button rather than a nested clickable element, so clicks no longer propagate.

@mui-bot

mui-bot commented Aug 6, 2026

Copy link
Copy Markdown

Netlify deploy preview

https://deploy-preview-5135--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 678b369

@forurmah

forurmah commented Aug 6, 2026

Copy link
Copy Markdown
Author

Looks like the CI failures are unrelated to this change — the CircleCI logs show:
"Orb codecov/codecov@5.4.3 not loaded. To use this orb, your organization must enable the 'Allow uncertified public orbs' feature in Org Settings > Security."
This seems to be an org-level CircleCI config issue rather than something caused by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DashboardLayout] Render NavigationItem.action as ListItem's secondaryAction

2 participants