-
Notifications
You must be signed in to change notification settings - Fork 163
Fixes video recording in training, unifies logs directory, and normalizes _HERE path #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @kevinzakka, I’m running into a strange loop with the Ruff checks! Locally everything looks clean after running Ruff + pre-commit: But on the PR checks I consistently see errors like: So CI wants one import ordering, while pre-commit locally forces the opposite. When I try to commit what CI seems to want, the pre-commit hook refuses the commit and rewrites the file back: After staging those changes and committing again, locally everything passes, but CI then fails again with the other version. Not sure if this is a config/version mismatch between pre-commit and CI, or something wrong in my PR itself. Maybe you already know what’s going on here and can point me in the right direction so I can get the PR checks to pass. |
|
@louislelay Delete the wandb directory in the src directory and it will fix the ruff issue :) |
|
Thank you @kevinzakka! 😆 |
Resolves comments for PR #24
2e89034 to
c2c0a6e
Compare
While encountering the following error during training with
--video:I corrected it by adding the same environment creation logic as in the
playscript, with a condition on therender_modebased on thevideoflag.During this change, I noticed that the
logsdirectory was being created at the same level as thetrainandplayscripts. To stay consistent with Isaac Lab, I moved it to the root of the repository.I also updated the way
_HEREis created (see this explanation):Path(__file__).resolve().parentThe same modifications were applied to the tracking play and train scripts, although I couldn’t test those as I don’t have a pretrained motion available