Colocalize manager configs and add comprehensive docstrings #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all *TermCfg classes from manager_term_config.py to their respective manager files (ActionTermCfg → action_manager.py, EventTermCfg → event_manager.py, etc.) and ManagerTermBaseCfg to manager_base.py. Delete the now-empty manager_term_config.py. Changes: - Add docstrings to all config classes with field-level documentation - Add docstrings to all manager classes (ActionManager, EventManager, etc.) - Document function-based vs class-based terms in ManagerTermBaseCfg - Unify API: change commands/curriculum from `| None = None` to `field(default_factory=dict)` for consistency with other manager configs - Update all `is not None` checks to truthy checks across ~15 files - Add "can be empty" notes to optional config fields - Export all config classes from managers/__init__.py - Update imports in docs and all dependent files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Document all fields in ObservationGroupCfg with clear descriptions of their purpose and behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Address review comment: prefer len(dict) > 0 over truthiness checks for better explicitness. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
*TermCfgclasses frommanager_term_config.pyto their respective manager files (e.g.,ActionTermCfg→action_manager.py)ManagerTermBaseCfgtomanager_base.pyand delete the now-emptymanager_term_config.pycommands/curriculumfrom| None = Nonetofield(default_factory=dict)for consistency with other manager configsis not Nonechecks to truthy checks across ~15 filesmanagers/__init__.pyTest plan
make checkpasses (ruff format, ruff check, ty check, pyright)make test-fastpasses (368 tests)🤖 Generated with Claude Code