Fix bash completions in subcommands #5710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serock3
force-pushed
the
bash_completions
branch
from
1907640 to
d2a9e32
Compare
MarkusPettersson98
approved these changes
Jan 22, 2024
There was a problem hiding this comment.
Nice!
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
MarkusPettersson98
force-pushed
the
bash_completions
branch
from
d2a9e32 to
2c6f04a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix shell completions for subcommands.
clap_completeincorrectly used package name instead of binary name for bash, causing completions to break for subcommands. I fixed this in an upstream PR, see clap-rs/clap#5256 and clap-rs/clap#5255. The PR is now merged and included inclap_completeversion4.4.8.Test this by building and installing the app on linux or mac, then verify completions for subcommands in a bash terminal.
Fixes DES-506
This change is