Add new csv based network creation mode #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waxlamp
approved these changes
May 17, 2022
|
|
||
|
|
||
| def create_csv_network(workspace: Workspace, serializer): | ||
| """Create a network from a link of tables (in request thread).""" |
There was a problem hiding this comment.
What is a "link of tables"?
There was a problem hiding this comment.
That's just a term I used to refer to creating a network by specifying links between existing workspace tables. Is there a better term we should use?
|
I'm going to just merge this now since you approved. If we decide to update things based on the discussion here we can always just follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend change for multinet-app/multinet-client#227