Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Task model for generic tasks #78

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Add Task model for generic tasks #78

merged 3 commits into from
Sep 1, 2021

Conversation

jjnesbitt
Copy link
Member

This PR is a prerequisite to #74, as it refactors part of Upload into the abstract base class Task, and inherits from it. To read more about how this works, see these django docs.

The full change list:

  • Refactor part of Upload into abstract Task class, from which it now inherits
  • Refactor ProcessUploadTask into MultinetCeleryTask, from which it now inherits
  • Move api/tasks/process to api/tasks/upload, as that better represents what's contained (upload tasks). Also move ProcessUploadTask into common.py.

Copy link
Collaborator

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for looping me in.

Copy link
Collaborator

@naglepuff naglepuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had one question for you, but looks good to me.

@jjnesbitt jjnesbitt merged commit cd5b08d into master Sep 1, 2021
@jjnesbitt jjnesbitt deleted the restructure-tasks branch September 1, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants