Feat/governance fixes #6490

dragos-rebegea · 2024-09-23T16:30:21Z

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

MX-15029: Accept multiple delegateVoting

MX-15032: MaxVotingDelayPeriodInEpochs

Mx 15033

…e-rc-v1.8.0-feat-governance-fixes # Conflicts: # vm/systemSmartContracts/governance.go # vm/systemSmartContracts/governance_test.go

…nce-fixes Merge rc v1.8.0 feat governance fixes

MX-15031: Add cancel method before voting start

Optimize GitHub workflows

Barnard to gov 4 nov

github-actions · 2024-11-04T10:43:27Z

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

Barnard governance 14 11

github-actions · 2024-11-14T12:56:27Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: d7718ca4e42873cb47a604b9860e53de141dabb4
Current Branch: feat/governance-fixes
mx-chain-go Target Branch: rc/barnard
mx-chain-simulator-go Target Branch: rc/barnard
mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

TIMESTAMP: 14112024-125625
PYTEST_EXIT_CODE: 0
🎉 MultiversX CI/CD Workflow Complete!

…-fixes

…d-feat-governance-fixes

…ance-fixes Merge rc/barnard into feat/governance-fixes

github-actions · 2025-02-28T16:09:32Z

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

mx-chain-go Commit Hash: cb63a2e6599a47ae23818a47d1c71bb797247035
Current Branch: feat/governance-fixes
mx-chain-go Target Branch: rc/barnard
mx-chain-simulator-go Target Branch: rc/barnard
mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

TIMESTAMP: 28022025-160930
PYTEST_EXIT_CODE: 0
🎉 MultiversX CI/CD Workflow Complete!

danidrasovean

Normal allin test: master-37ab7adf91 -> feat/governance-fixes

--- Specific errors ---

block hash does not match 0
wrong nonce in block 33
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 9
Nr. of all WARNS: 773
Nr. of new ERRORS: 9
Nr. of new WARNS: 545

/------/

--- System test go ---

All scenarios from system-test-go are OK!
/------/

dragos-rebegea and others added 30 commits January 19, 2024 18:19

MX-15029: Accept multiple delegateVoting

6ef1556

MX-15029: make saveUserVotes backword compatible

d50e7d9

MX-15029: add deactivation propose flag

3a04c1a

MX-15029: fixes after review

2c233f4

MX-15047: add gasUsage for changeConfig

df53ca0

MX-15032: MaxVotingDelayPeriodInEpochs

640162f

MX-15032: fix tests

c45d12b

MX-15029: fix naming

5cb1114

MX-15047: add gasUsage for ClaimAccumulatedFees

87e0efd

MX-15029: check double vote is not allowed

9c89cc3

MX-15029: fix enableEpochsHandler test

a0e0d59

MX-15029: fixes after review

5693577

MX-15029: fixes after review

f178fc7

MX-15029: test delegateVote with stored OngoingListV1

898267e

MX-15029: remove unused method

70fde80

MX-15029: remove unreachable code

067d880

MX-15029: add more tests

78a4644

Merge pull request #5857 from multiversx/MX-15029

8fa9408

MX-15029: Accept multiple delegateVoting

MX-15033: processLastEndedNonce

0e1940d

MX-15033: clearEndedProposals implementation

c5103a0

Merge branch 'feat/governance-fixes' into MX-15032

5eee09b

MX-15033: add more tests

2a18830

Merge branch 'feat/governance-fixes' into MX-15047

c4a238b

MX-15032: fix comments

eb8e6b6

MX-15033: fixes after review

20651ec

Merge pull request #5877 from multiversx/MX-15032

2e55c60

MX-15032: MaxVotingDelayPeriodInEpochs

Merge branch 'feat/governance-fixes' into MX-15047

3bd015c

MX-15033: fixes after review

07f949b

Merge branch 'feat/governance-fixes' into MX-15033

b3f5b09

MX-15033: fixes after review

1a111a2

dragos-rebegea and others added 10 commits September 24, 2024 11:42

Merge pull request #5922 from multiversx/MX-15033

5739ad1

Mx 15033

Merge remote-tracking branch 'origin/feat/governance-fixes' into merg…

fe2a6cb

…e-rc-v1.8.0-feat-governance-fixes # Conflicts: # vm/systemSmartContracts/governance.go # vm/systemSmartContracts/governance_test.go

fixes after merge

5b4b719

Merge pull request #6491 from multiversx/merge-rc-v1.8.0-feat-governa…

51bcc3e

…nce-fixes Merge rc v1.8.0 feat governance fixes

MX-15031: Add cancel method before voting start

a7681da

MX-15031: refactor and tests

f5da2c9

MX-15031: add extra check

1a2a505

MX-15031: fix test

499b2f6

MX-15031: add boundary tests

7791a43

Merge pull request #6496 from multiversx/MX-15031

233c48d

MX-15031: Add cancel method before voting start

dragos-rebegea marked this pull request as ready for review October 2, 2024 09:58

iulianpascalau previously approved these changes Oct 2, 2024

View reviewed changes

sasurobert previously approved these changes Oct 2, 2024

View reviewed changes

andreibancioiu and others added 2 commits October 3, 2024 17:37

Optimize GitHub workflows.

46f442d

Merge pull request #6519 from multiversx/optimize-workflows-governance

4077ac2

Optimize GitHub workflows

AdoAdoAdo dismissed stale reviews from sasurobert and iulianpascalau via 4077ac2 October 4, 2024 07:37

sasurobert added 2 commits November 4, 2024 12:30

Merge branch 'rc/barnard' into barnard-to-gov-4-nov

bf4ebb5

Merge pull request #6582 from multiversx/barnard-to-gov-4-nov

ab07ac0

Barnard to gov 4 nov

sasurobert approved these changes Nov 4, 2024

View reviewed changes

sasurobert added 2 commits November 14, 2024 12:59

Merge branch 'rc/barnard' into barnard-governance-14-11

5538109

Merge pull request #6608 from multiversx/barnard-governance-14-11

d7718ca

Barnard governance 14 11

dragos-rebegea and others added 3 commits February 28, 2025 15:21

Merge remote-tracking branch 'origin/rc/barnard' into feat/governance…

145151b

…-fixes

Merge remote-tracking branch 'origin/rc/barnard' into merge-rc-barnar…

59d7eed

…d-feat-governance-fixes

Merge pull request #6845 from multiversx/merge-rc-barnard-feat-govern…

cb63a2e

…ance-fixes Merge rc/barnard into feat/governance-fixes

iulianpascalau approved these changes Mar 4, 2025

View reviewed changes

danidrasovean approved these changes Mar 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/governance fixes #6490

Feat/governance fixes #6490

dragos-rebegea commented Sep 23, 2024

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Feb 28, 2025

danidrasovean left a comment

Feat/governance fixes #6490

Are you sure you want to change the base?

Feat/governance fixes #6490

Conversation

dragos-rebegea commented Sep 23, 2024

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

github-actions bot commented Nov 4, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Feb 28, 2025

danidrasovean left a comment

Choose a reason for hiding this comment