Added new config for rewards #6841
Conversation
…d duplicated mock
sstanculeanu
added
type:bug
|
|
|
Run Tests: |
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
epochStart/metachain/baseRewards.go
Outdated
| return nil, 0, epochStart.ErrNilProtocolSustainabilityAddress | ||
| } | ||
|
|
||
| address, err := brc.pubkeyConverter.Decode(protocolSustainabilityAddressForEpoch) |
There was a problem hiding this comment.
you should make the decodes only once - when creating the setup. Not at every epoch.
There was a problem hiding this comment.
indeed we should detect any config error as early as possible, pushed
|
Run Tests: |
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
There was a problem hiding this comment.
Normal allin test: master-37ab7adf91 -> new_rewards_config-c8906c82b3
--- Specific errors ---
block hash does not match 11
wrong nonce in block 31
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0
/------/
--- Statistics ---
Nr. of all ERRORS: 0
Nr. of all WARNS: 239
Nr. of new ERRORS: 0
Nr. of new WARNS: 0
Nr. of PANICS: 0
Nodes with panic: []
/------/
--- System test go ---
All scenarios from system-test-go are OK!
/------/
| rewardsHandler := &economicsmocks.EconomicsHandlerStub{ | ||
| RewardsTopUpGradientPointCalled: func() *big.Int { | ||
| rewardsHandler := &economicsmocks.EconomicsHandlerMock{ | ||
| RewardsTopUpGradientPointInEpochCalled: func(epoch uint32) *big.Int { |
There was a problem hiding this comment.
unused epoch argument, maybe use an _ ?
| return big.NewInt(0).Set(rewardsTopUpGradientPoint) | ||
| }, | ||
| RewardsTopUpFactorCalled: func() float64 { | ||
| RewardsTopUpFactorInEpochCalled: func(epoch uint32) float64 { |
|
|
|
Run Tests: |
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?