Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate transfer and execute with return error #6852

Open
wants to merge 3 commits into
base: rc/barnard
Choose a base branch
from

Conversation

laurci
Copy link
Contributor

@laurci laurci commented Mar 4, 2025

Reasoning behind the pull request

  • Integrate new version of VM with the new transfer and execute and return error hook.

Related PRs

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@laurci laurci changed the title update vm version integrate transfer and execute with return error Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: aacd0ff50a22d9f78c01d8adf23d341a4eabef37
  • Current Branch: transfer-with-return-err
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 04032025-115449
  • PYTEST_EXIT_CODE: 1
    🎉 MultiversX CI/CD Workflow Complete!

sstanculeanu
sstanculeanu previously approved these changes Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: ae061b7147052f7e7508cdadc1d6d94fa38e9923
  • Current Branch: transfer-with-return-err
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 04032025-121427
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

danidrasovean
danidrasovean previously approved these changes Mar 5, 2025
Copy link
Collaborator

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: master-37ab7adf91 -> transfer-with-return-err-ae061b7147

--- Specific errors ---

block hash does not match 10
wrong nonce in block 35
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 9
Nr. of all WARNS: 318
Nr. of new ERRORS: 9
Nr. of new WARNS: 78

/------/

--- System test go ---

All scenarios from system-test-go are OK!
/------/

@laurci laurci dismissed stale reviews from danidrasovean and sstanculeanu via 16f0269 March 6, 2025 10:42
@multiversx multiversx deleted a comment from github-actions bot Mar 6, 2025
@multiversx multiversx deleted a comment from github-actions bot Mar 6, 2025
@multiversx multiversx deleted a comment from github-actions bot Mar 6, 2025
@multiversx multiversx deleted a comment from github-actions bot Mar 6, 2025
@multiversx multiversx deleted a comment from github-actions bot Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 16f0269bd36a51db8fab7800e4624b759f9da4a4
  • Current Branch: transfer-with-return-err
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 06032025-120239
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants