Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge storage/txcache into Node #6854

Merged
merged 226 commits into from
Mar 7, 2025
Merged

Conversation

andreibancioiu
Copy link
Collaborator

@andreibancioiu andreibancioiu commented Mar 4, 2025

Logic & lifecycle of txcache is quite tightly coupled to the logic & lifecycle of the Node. Therefore, we move txcache back into mx-chain-go.

Steps involved

Actual code movement - GIT history is retained. Though, commit signatures are lost.

git clone [email protected]:multiversx/mx-chain-go.git
git clone [email protected]:multiversx/mx-chain-storage-go.git

cd mx-chain-storage-go
git filter-repo --subdirectory-filter txcache --to-subdirectory-filter txcache

cd ../mx-chain-go

git checkout feat/gas-station
git checkout -b MX-16624-move-txcache
git remote add storage ../mx-chain-storage-go
git fetch storage
git merge --allow-unrelated-histories storage/main
git remote remove storage
git push origin

Afterwards:

  • move some testing facilities from storage-go
  • adjust some imports
  • adjust some interfaces

How to review

git clone -b MX-16624-move-txcache [email protected]:multiversx/mx-chain-go.git
git clone -b main [email protected]:multiversx/mx-chain-storage-go.git
git diff --no-index mx-chain-go/txcache mx-chain-storage-go/txcache

Then, have a look over the changed files outside of txcache.

References:

bogdan-rosianu and others added 30 commits August 8, 2022 14:15
move errors to common package
rebranding: rename module, adapt imports
rebranding: rename module, adapt imports
…ersisters

Merge rc 1.7.next1 to common persisters
…ss" (no gaps, no duplicates). Sketch some tests.
andreibancioiu and others added 24 commits November 29, 2024 16:24
Merge main into mempool, fix linter issues
Mempool: add benchmarks for addition in worst case
Adjust benchmarks, lower "maxNum" when selecting transactions
…l "heap items" (within a selection session).
Handle relayed V3 transactions in selection
@andreibancioiu andreibancioiu self-assigned this Mar 4, 2025
@andreibancioiu andreibancioiu marked this pull request as ready for review March 4, 2025 20:43
@andreibancioiu andreibancioiu merged commit 59d55c9 into feat/gas-station Mar 7, 2025
6 checks passed
@andreibancioiu andreibancioiu deleted the MX-16624-move-txcache branch March 7, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants