-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge storage/txcache into Node #6854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move errors to common package
Small refactor
rebranding: rename module, adapt imports
rebranding: rename module, adapt imports
Merge main into rc 1.5.0
Merge main rc v1.7.0 2024.01.29
…ersisters Merge rc 1.7.next1 to common persisters
Feat/refactor persister factory
…ss" (no gaps, no duplicates). Sketch some tests.
Merge main into mempool, fix linter issues
Mempool: add benchmarks for addition in worst case
Adjust benchmarks, lower "maxNum" when selecting transactions
Mempool improvements
Rc/spica patch mempool
…l "heap items" (within a selection session).
Handle relayed V3 transactions in selection
Feat/relayedv3
Rc/spica patch relayedv3
sstanculeanu
approved these changes
Mar 5, 2025
danidrasovean
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic & lifecycle of txcache is quite tightly coupled to the logic & lifecycle of the Node. Therefore, we move txcache back into mx-chain-go.
Steps involved
Actual code movement - GIT history is retained. Though, commit signatures are lost.
Afterwards:
How to review
Then, have a look over the changed files outside of
txcache
.References: