Integrated the delegation factory #364
Conversation
| "--arguments", "0", | ||
| "--send", "--wait-result" | ||
| ]) | ||
| assert True if return_code else False |
| @@ -320,43 +318,6 @@ def deploy(args: Any): | |||
| _send_or_simulate(tx, contract_address, args) | |||
|
|
|||
|
|
|||
| def _prepare_sender(args: Any) -> Account: | |||
There was a problem hiding this comment.
Just to double/triple check - deployments still work with Ledger now, correct?
There was a problem hiding this comment.
Well, I've changed the cli_shared.prepare_account() function, to load a LedgerAccount as previously done in the _prepare_sender() function. Now, since it's the same, I assume all operations should work using a Ledger device.
|
|
||
|
|
||
| class DelegationOperations: | ||
| def __init__(self, config: IConfig) -> None: |
There was a problem hiding this comment.
Can use the config class (the concrete class) directly, since we don't necessarily think of the components in mxpy as reusable objects (not a library). Can also stay as it is 👍
There was a problem hiding this comment.
I've done it like this to match the SmartContract class. Will leave it as it is for now.
| tx.version = int(args.version) | ||
| tx.options = int(args.options) | ||
| tx.guardian = args.guardian | ||
| tx.signature = bytes.fromhex(owner.sign_transaction(tx)) |
There was a problem hiding this comment.
In other places, the sign_transaction() function is invoked in cli_....py files. But can also stay here.
Perhaps rename functions to have the prefix create_ instead of get_, since they create transactions? Or prepare.
There was a problem hiding this comment.
Renamed with the prefix prepare_.
|
|
||
| return validator_public_keys | ||
|
|
||
| def _get_public_keys_and_signed_messages(self, args: Any) -> Tuple[List[ValidatorPublicKey], List[bytes]]: |
There was a problem hiding this comment.
Maybe some of the logic can be moved to ValidatorsFile? E.g. load_secret_keys()? Or even load_signers() - and the returned object (signers) allows us to both sign a message, and get the underlying public keys.
There was a problem hiding this comment.
Made a function load_signers() inside the ValidatorsFile class that returns a list of ValidatorSigners.
|
|
||
| return public_keys, signed_messages | ||
|
|
||
| def _get_pubkey_for_signing(self, args: Any) -> bytes: |
There was a problem hiding this comment.
_to_be_signed(), instead of _for_signing().
|
|
||
| return account.address.get_public_key() | ||
|
|
||
| def __get_empty_transaction(self) -> Transaction: |
There was a problem hiding this comment.
Instead, can we do else raise Error("...")?
There was a problem hiding this comment.
That sounds good. Done!
| signed_messages.append(signed_message) | ||
|
|
||
| return public_keys, signed_messages | ||
|
|
||
| def _get_pubkey_for_signing(self, args: Any) -> bytes: | ||
| def _get_pubkey_to_be_signed(self, args: Any) -> bytes: |
There was a problem hiding this comment.
Now I see, this does not work with Ledger yet.
| ${CLI} --verbose validator stake --pem="${USERS}/bob.pem" --value="2500${DENOMINATION}" --validators-file=./testdata/validators.json --reward-address=${REWARD_ADDRESS} --chain=${CHAIN_ID} --proxy=${PROXY} --estimate-gas --nonce=300 --send || return 1 | ||
| ${CLI} --verbose validator stake --pem="${USERS}/bob.pem" --value="2500${DENOMINATION}" --validators-file=./testdata/validators.json --reward-address=${REWARD_ADDRESS} --chain=${CHAIN_ID} --proxy=${PROXY} --estimate-gas --nonce=300 || return 1 |
There was a problem hiding this comment.
The nonce was previously set to a higher number so that the transaction would stay in the mempool. Since the nonce limit has been lowered, so that the protocol only accepts transactions with max_nonce=current_nonce + 100 and because the address used it's Bob's address which is a public one, the tests would keep failing on every PR.
Now using the
DelegationFactoryfromsdk-py-coreto perform delegation operations.Also added tests.