Integrate latest sdk-py v1 #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main into feat/next
danielailie
approved these changes
Jan 29, 2025
andreibancioiu
approved these changes
Jan 29, 2025
| data = "makeNewContractFromValidatorData@" + args_to_string([max_cap, fee]) | ||
|
|
||
| serializer = Serializer() | ||
| data = "makeNewContractFromValidatorData@" + serializer.serialize([BigUIntValue(max_cap), BigUIntValue(fee)]) |
There was a problem hiding this comment.
Maybe we should have this function in the sdk-py (factories, controllers), as well?
There was a problem hiding this comment.
indeed, will be added.
| ... | ||
|
|
||
|
|
||
| class Simulation(ISerializable): | ||
| def __init__(self, simulate_response: ISimulateResponse) -> None: | ||
| def __init__(self, simulate_response: TransactionOnNetwork) -> None: |
There was a problem hiding this comment.
Just a double-check, do we have some CI tests for this functionality, as well?
There was a problem hiding this comment.
to be honest, I don't think we have. The interface was indeed a TransactionOnNetwork object that was only converted to a dictionary.
| @@ -211,8 +203,8 @@ def tx_to_dictionary_as_inner_for_relayed_V1(tx: Transaction) -> Dict[str, Any]: | |||
| dictionary: Dict[str, Any] = {} | |||
|
|
|||
| dictionary["nonce"] = tx.nonce | |||
| dictionary["sender"] = base64.b64encode(Address.new_from_bech32(tx.sender).get_public_key()).decode() | |||
| dictionary["receiver"] = base64.b64encode(Address.new_from_bech32(tx.receiver).get_public_key()).decode() | |||
| dictionary["sender"] = base64.b64encode(tx.sender.get_public_key()).decode() | |||
There was a problem hiding this comment.
Let's remove tx_to_dictionary_as_inner_for_relayed_V1 and legacy relayed V1 support in v10 🤞
| rich==13.3.4 | ||
| argcomplete==3.2.2 | ||
|
|
||
| multiversx-sdk==0.19.0 | ||
| multiversx-sdk==1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.