Changed to black formatter and added pre-commit #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
approved these changes
Jan 29, 2025
|
|
||
| # fmt: off |
There was a problem hiding this comment.
it is needed for black to not format the code, because it moves the three dots on the same line and the flake complains
| @@ -1,7 +1,9 @@ | |||
| from pathlib import Path | |||
|
|
|||
| from multiversx_sdk_cli.projects.constants import (OLD_PROJECT_CONFIG_FILENAME, | |||
| PROJECT_CONFIG_FILENAME) | |||
| from multiversx_sdk_cli.projects.constants import ( | |||
There was a problem hiding this comment.
Maybe remove this file soon?
There was a problem hiding this comment.
will be removed indeed.
|
|
||
| from multiversx_sdk_cli.config import get_address_hrp | ||
| from multiversx_sdk_cli.errors import BadUsage | ||
| from multiversx_sdk_cli.validators.validators_file import ValidatorsFile | ||
|
|
||
|
|
||
| # fmt: off |
| @@ -9,9 +8,9 @@ | |||
| logger = logging.getLogger("downloader") | |||
|
|
|||
| CHUNK_SIZE = 1024 * 16 | |||
| LINECLEAR = '\r' + ' ' * 20 + '\r' | |||
| LINECLEAR = "\r" + " " * 20 + "\r" | |||
There was a problem hiding this comment.
Maybe, in a future PR, replace this logic with the package wget?
There was a problem hiding this comment.
will keep it in mind to replace it in a future PR.
| @@ -3,6 +3,7 @@ | |||
| from multiversx_sdk import Transaction | |||
|
|
|||
|
|
|||
| # fmt: off | |||
danielailie
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.