Estimate gas limit by default whenever possible #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiversx_sdk_cli/cli_delegation.py
Outdated
| gas_limit = 0 if args.estimate_gas else args.gas_limit | ||
| chain_id = cli_shared.get_chain_id(args.chain, args.proxy) | ||
| config = TransactionsFactoryConfig(chain_id) | ||
| delegation = DelegationOperations(config) |
multiversx_sdk_cli/cli_delegation.py
Outdated
| gas_limit = 0 if args.estimate_gas else args.gas_limit | ||
| chain_id = cli_shared.get_chain_id(args.chain, args.proxy) | ||
| config = TransactionsFactoryConfig(chain_id) | ||
| delegation = DelegationOperations(config) |
| @@ -54,7 +53,7 @@ def create_transaction_for_staking( | |||
| rewards_address=rewards_address, | |||
| ) | |||
|
|
|||
| if estimate_gas: | |||
| if not gas_limit: | |||
There was a problem hiding this comment.
I thought we can drop self.estimate_* functions, since gas estimation is performed by controllers in sdk-py.
There was a problem hiding this comment.
Here, the transactions are not created using a controller from sdk-py. This will be changed in a later PR. We still left the --gas-limit argument in case a user wants to specify the gas.
| proxy = ProxyNetworkProvider(url=args.proxy, config=network_provider_config) | ||
| args.nonce = proxy.get_account(account.address).nonce | ||
|
|
||
|
|
||
| def get_current_nonce_for_address(address: Address, proxy_url: Union[str, None]) -> int: |
There was a problem hiding this comment.
Previously reviewed 💭
multiversx_sdk_cli/cli_shared.py
Outdated
|
|
||
|
|
||
| def prepare_sender(args: Any): | ||
| """Reurns a tuple containing the sender's account and the account nonce. |
There was a problem hiding this comment.
Comment is outdated.
| @@ -57,7 +56,6 @@ def test_create_new_delegation_contract_with_provided_gas_limit(capsys: Any): | |||
| str(alice), | |||
| "--nonce", | |||
| "7", | |||
| "--estimate-gas", | |||
There was a problem hiding this comment.
We should document this breaking change in the PR description (so that we don't forget about it when writing the release notes).
There was a problem hiding this comment.
Added a short description.
andreibancioiu
approved these changes
Mar 4, 2025
danielailie
approved these changes
Mar 4, 2025
danielailie
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--estimate-gasflag was removed from all commands. The gas limit is now estimated by default wherever possible (excluding smart contract transactions).