Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flow for guarded accounts #495

Merged
merged 6 commits into from
Mar 24, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
set guardian from args if provided
popenta committed Mar 17, 2025
commit 55ae23c5936d3230f183bc322d201c1f2d8615a5
24 changes: 14 additions & 10 deletions multiversx_sdk_cli/cli_shared.py
Original file line number Diff line number Diff line change
@@ -345,26 +345,30 @@ def get_guardian_and_relayer_data(sender: str, args: Any) -> GuardianRelayerData
relayer_address=relayer_address,
)

_get_guardian_data_from_network(sender, args, guardian_and_relayer_data)
if guardian_and_relayer_data.guardian_address:
guardian_and_relayer_data.guardian_service_url = args.guardian_service_url
guardian_and_relayer_data.guardian_2fa_code = args.guardian_2fa_code
else:
_get_guardian_data_from_network(sender, args, guardian_and_relayer_data)

return guardian_and_relayer_data


def _get_guardian_data_from_network(sender: str, args: Any, guardian_and_relayer_data: GuardianRelayerData):
"""Updates the `guardian_and_relayer_data` parameter, that is later used."""

# if guardian not provided, get guardian from the network
if not guardian_and_relayer_data.guardian_address:
guardian_data = _get_guardian_data(sender, args.proxy)
guardian_data = _get_guardian_data(sender, args.proxy)

if guardian_data:
guardian_and_relayer_data.guardian_address = Address.new_from_bech32(guardian_data["guardian_address"])
if guardian_data:
guardian_and_relayer_data.guardian_address = Address.new_from_bech32(guardian_data["guardian_address"])

# if tcs is used, set url, else get service url from args
tcs_url = guardian_data["cosigner_service_url"]
guardian_and_relayer_data.guardian_service_url = tcs_url if tcs_url else args.guardian_service_url
# if tcs is used, set url, else get service url from args
tcs_url = guardian_data["cosigner_service_url"]
guardian_and_relayer_data.guardian_service_url = tcs_url if tcs_url else args.guardian_service_url

if guardian_and_relayer_data.guardian_service_url:
guardian_and_relayer_data.guardian_2fa_code = _get_2fa_code(args)
if guardian_and_relayer_data.guardian_service_url:
guardian_and_relayer_data.guardian_2fa_code = _get_2fa_code(args)


def _get_guardian_data(address: str, proxy_url: str) -> Union[dict[str, str], None]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reference for double checking / no additional action to take: