Skip to content

Conversation

@codegod100
Copy link
Collaborator

initial stab at tests. we are about 50% total codebase coverage. i'll continue to add more as we go. right now you need to use bun to run vitest but I'm working on a fix where we can run from deno

@codegod100
Copy link
Collaborator Author

denoland/deno#23882 looks like known issue

@michaelwschultz
Copy link
Collaborator

LOVE this, thanks for adding these! Gonna run them locally. Should we get this in sooner rather than later? We can always add to it as we go. Would you mind writing guidelines for others to follow when writing/creating tests?

@codegod100
Copy link
Collaborator Author

I guess I can write something up. The biggest "north star" I was following is running "bun run test --coverage" and adding more tests to statements that need coverage

@codegod100
Copy link
Collaborator Author

added TESTING.md with examples and explanation of testing guidelines

@michaelwschultz
Copy link
Collaborator

Thank you, thank you. Will get this merged later today!

deno.lock Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, don't want to remove this file.

@michaelwschultz
Copy link
Collaborator

@codegod100 Do you actually mind if we hold off on this for a bit? Due to the fact that the app is changing so rapidly right now. I'm more worried this is going to slow us down vs speed us up. I'd also be alright with placing these in a separate /tests and not requiring them be run right now. Then we can update and enable them later. Though having a history of this PR is probably enough. I really appreciate the thought, and the work but let's revisit this after we launch alpha 3.

@codegod100
Copy link
Collaborator Author

codegod100 commented Apr 28, 2025

Whatever you wanna do is fine with me 👍

@codegod100 codegod100 marked this pull request as draft April 28, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants