-
Notifications
You must be signed in to change notification settings - Fork 20
Tests #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tests #182
Conversation
|
denoland/deno#23882 looks like known issue |
|
LOVE this, thanks for adding these! Gonna run them locally. Should we get this in sooner rather than later? We can always add to it as we go. Would you mind writing guidelines for others to follow when writing/creating tests? |
|
I guess I can write something up. The biggest "north star" I was following is running "bun run test --coverage" and adding more tests to statements that need coverage |
|
added TESTING.md with examples and explanation of testing guidelines |
|
Thank you, thank you. Will get this merged later today! |
deno.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, don't want to remove this file.
|
@codegod100 Do you actually mind if we hold off on this for a bit? Due to the fact that the app is changing so rapidly right now. I'm more worried this is going to slow us down vs speed us up. I'd also be alright with placing these in a separate |
|
Whatever you wanna do is fine with me 👍 |
initial stab at tests. we are about 50% total codebase coverage. i'll continue to add more as we go. right now you need to use bun to run vitest but I'm working on a fix where we can run from deno