Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use Loro for page revision tracking. #282

Merged
merged 7 commits into from
Jan 25, 2025

Conversation

Henry-Wow
Copy link
Contributor

Changes

  1. Integrate loro-prosemirror into Weird (Frontend)
  2. Integrate the history visualization into Weird (Frontend)

result

Copy link

github-actions bot commented Jan 13, 2025

All contributors have signed the CLC ✍️ ✅
Posted by the CLC Assistant Lite bot.

@Henry-Wow
Copy link
Contributor Author

I have read the CLC Document and I hereby sign the CLC

github-actions bot added a commit that referenced this pull request Jan 13, 2025
@Henry-Wow Henry-Wow marked this pull request as draft January 13, 2025 09:18
@zicklag
Copy link
Collaborator

zicklag commented Jan 19, 2025

@Henry-Wow I'm going to force push to this branch to rebase on top of the current main and then start pushing the remaining updates to get it hooked up with the backend.

I'm just warning you so that you're aware before I mess with the git history in your branch.

zicklag added a commit that referenced this pull request Jan 23, 2025
@zicklag zicklag marked this pull request as ready for review January 25, 2025 01:02
@zicklag zicklag changed the title feat: Integrate loro-prosemirror and history visualization into Weird (Frontend) feat: use Loro for page revision tracking. Jan 25, 2025
@zicklag
Copy link
Collaborator

zicklag commented Jan 25, 2025

I pushed updates to integrate Loro minimally to use it for the page revisions, and removed the old way of handling page revisions.

I kept the new Loro editor-with-history components in the codebase, but haven't added them to the UI yet, because we still need to get the markdown editor properly synced with the rich text editor.

Lots of room for improvement, including the ability to revert changes, but we've got a good start here.

Thanks for your help @Henry-Wow!

@zicklag zicklag added this pull request to the merge queue Jan 25, 2025
Merged via the queue into muni-town:main with commit a476b3e Jan 25, 2025
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants