⬆️ Update jeff-mlir - #2018
Draft
denialhaag wants to merge 1 commit into
Draft
Conversation
denialhaag
added
enhancement
denialhaag
commented
Aug 7, 2026
Comment on lines
319
to
+329
| /** | ||
| * @brief Write serialized `jeff` bytes to an output file or standard output. | ||
| */ | ||
| static LogicalResult writeJeffOutput(ModuleOp mod, const StringRef filename) { | ||
| if (filename != "-") { | ||
| if (failed(serializeToFile(mod, filename))) { | ||
| llvm::errs() << "Failed to write jeff file '" << filename << "'.\n"; | ||
| return failure(); | ||
| } | ||
| return success(); | ||
| } |
Member
Author
There was a problem hiding this comment.
@burgholzer, does it even make sense to write jeff to standard output? 🤔
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
jeff-mlirto make use of the new signature ofserializeToFile. It must remain open until PennyLaneAI/jeff-mlir#27 is merged and released.Checklist
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.I have added migration instructions to the upgrade guide (if needed).