-
Notifications
You must be signed in to change notification settings - Fork 41
✨ Collect clifford blocks #885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
212533c
3f64b2f
5db7ac5
4995e47
62004e5
1656046
8c811bd
5812c72
d9d2132
3282c67
43d18ae
088ada5
486e225
66ed0fc
e1ffb25
0ae9525
d7264a0
a12f11a
7eb95fc
5555b8e
e5de02d
6e728cb
71e8bc6
f771766
d97eef5
227d2ec
5ce85b4
326c5b9
ace9eaf
6ff54c3
479d3ba
e0a4e50
a475fab
337b2ef
16ff394
5ad710c
c226bf1
b16ac7b
e723671
de14645
0f4e9fa
3d16b8c
32b333a
fcdf42e
d3d6c51
801a423
54e5b4b
3fd00a8
d715a9c
eb463ac
ff847a1
15ae2b5
5c7f8bc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
burgholzer marked this conversation as resolved.
Show resolved
Hide resolved
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I fixed up a couple of things in the other parts of the PR, but these tests here are still broken. They do not assert the right behaviour/structure of the resulting circuit and, what makes it worse, the implementation currently does not produce correct results, as can be seen fro example from the i: 0 1
1: sx |
2: | sxd
3: t |
4: | t
5: x |
6: | x
o: 0 1
i: 0 1
1:--------
: | sxd
: | x
---------
2:--------
: sx |
: x |
---------
3: | t
4: t |
o: 0 1 which clearly shows an incorrect grouping and ordering of the operations. |
Check notice
Code scanning / CodeQL
Commented-out code Note