Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Migrate and Refactor Approximation Functionality from DDSim Package #908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ Migrate and Refactor Approximation Functionality from DDSim Package #908
Changes from all commits
804f39b
454d5bc
afb6b6f
182b48a
2a7b5cd
080774b
43b9569
82580a7
3919879
1f841ad
22c4e55
1d3a7e5
472958c
017628b
5dbef62
4a6a156
14eb307
378800a
0c77295
7dce932
40f63c3
92dba38
052f6f6
014f369
3780739
bf74fe7
1543950
544b81b
b2273d1
ce1ad59
f415fb1
964d2e2
23bd171
349f166
044a9d4
1c8c556
5c8489e
6b17acf
25f7de9
84a9f06
a8dc8b9
ecdb253
3b234b7
a7cc5fd
4fa3524
e642827
ab939de
90bb242
ae89cdf
f95f388
4e638b7
7fa8900
6015b69
42ac8df
9d79391
4a8d67b
5676056
bf5d09c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once all the details of the implementation are clarified, I believe it would be helpful to add a brief description of the complexity of the approximation operation to the docstring here.
Check warning on line 25 in src/dd/Approximation.cpp
src/dd/Approximation.cpp:25:63 [misc-include-cleaner]
Check warning on line 43 in src/dd/Approximation.cpp
src/dd/Approximation.cpp:43:3 [misc-include-cleaner]
Check warning on line 43 in src/dd/Approximation.cpp
src/dd/Approximation.cpp:43:3 [misc-const-correctness]