-
Notifications
You must be signed in to change notification settings - Fork 41
✨ Implement mark-and-sweep garbage collection #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
q-inho
wants to merge
21
commits into
munich-quantum-toolkit:main
from
q-inho:mark_and_sweep_garbage_DD_package
Closed
Changes from 7 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
a9d5ffe
✨ Implement mark-and-sweep garbage collection and update reference ma…
q-inho 8a3646e
✨ Refactor garbage collection root management to use unordered_set fo…
q-inho 46d7a71
Merge branch 'main' into mark_and_sweep_garbage_DD_package
q-inho e03554c
Update include/mqt-core/dd/Node.hpp
q-inho 73ef0ff
✨ Enhance mark-and-sweep garbage collection with explicit reference c…
q-inho 2f216ef
Merge branch 'main' into mark_and_sweep_garbage_DD_package
q-inho ad64bf9
Fix RealNumber reference count assertion
q-inho 46e7aa9
Update include/mqt-core/dd/Package.hpp
q-inho c88a319
Refactor RealNumber, ComplexNumber and UniqueTable for Improved Memor…
q-inho 143c1db
constexpr pointer operations in `RealNumber`
q-inho 6671038
RealNumber with mark and unmark functions
q-inho f5877d0
Update tests to use makeBasisState instead of makeZeroState for bette…
q-inho bed77c0
Revert changes
q-inho 4a1a121
Merge remote-tracking branch 'upstream/main' into mark_and_sweep_garb…
q-inho 7e768b6
Change the call to `makeZeroState` to the `dd` namespace
q-inho ce4afda
add `bit_cast` support for clearMark function in RealNumber for Build…
q-inho c51a5de
Merge branch 'main' into mark_and_sweep_garbage_DD_package
q-inho d75f141
Replace constexp to inline due to build failure on Window
q-inho d6dec27
Remove constexpr from exactlyZero and exactlyOne methods in Complex s…
q-inho 8344696
Remove constexpr from isStaticComplex method in ComplexNumbers class
q-inho 26ba8d5
🚧 work-in-progress cleanup
burgholzer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should not be necessary if I am not overlooking things.
The Edge class defines a hash function at the very end of this file.
And the equality operator defined for the Edge class should also be sufficient here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right.
Edge
already provides them.