Skip to content

Add stepwise intermediate reward for RL #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 71 commits into
base: main
Choose a base branch
from
Draft

Add stepwise intermediate reward for RL #526

wants to merge 71 commits into from

Conversation

@Shaobo-Zhou
Copy link
Contributor

@Shaobo-Zhou Shaobo-Zhou commented Nov 26, 2025

Description

Please include a summary of the change and, if applicable, which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes #(issue)

Checklist:

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

Shaobo Zhou and others added 30 commits March 29, 2025 19:20
Update predictor(adding callbacks)
129b60f
Update
08889bd
Restore helper.py and predictor.py to match upstream
e2ff3fe
Merge remote-tracking branch 'upstream/main'
1c32d15
Implement new mapping actions
78dc1aa 
Update action space and feature space

Update actions

Update action space
Fix: resolve pre-commit issues and add missing annotations
a3ba836 
Fix: resolve pre-commit issues and add missing annotations

Fix: resolve pre-commit issues and add missing annotations

Remove example_test.py

Remove example_test.py
Fix: resolve pre-commit issues and add missing annotations
5935e6f 
Fix: resolve pre-commit issues and add missing annotations

Fix: resolve pre-commit issues and add missing annotations

Fix: resolve pre-commit issues and add missing annotations
Fix: resolve pre-commit issues and add missing annotations
f71fb29
Fix: resolve pre-commit issues and add missing annotations
3c7592b
Fix mypy errors
6db5c27
Fix mypy errors
47841c5
Fix dependencies issues
b1ac8ce
Fix dependency issues
5f8473c
Add missing zip file
7491ec0
Fix issue with Python 3.13
3346842
@Shaobo-Zhou
Merge branch 'main' into hybrid-mapping
6f7a73c 
Signed-off-by: Shaobo-Zhou <[email protected]>
Remove Python 3.13 from noxfile.py due to compatibility issue
6c67349
Skip minimums session on Windows due to CI slowness
2692b96
Fix bugs
f4874e6 
Fix bugs

Fix bugs

Fix bugs
Fix bugs
54eec91
@Shaobo-Zhou
Use default Qiskit settings for VF2Layout and add assertion for nativ…
845f7de 
…e gate check
@Shaobo-Zhou
Debug
3418936
@Shaobo-Zhou
Fix missing argument
ae870cc
@Shaobo-Zhou
Fix warning issues
861bc62
@Shaobo-Zhou
Fix window runtime warning problem
fa989b6
@Shaobo-Zhou
Fix window runtime warning problem
405bd39
@Shaobo-Zhou
Add time limit for VF2PostLayout
7b2f321
@Shaobo-Zhou
Fix windows runtime warning problem
b67d0a6 
Fix windows runtime warning problem

Fix windows runtime warning issue
@Shaobo-Zhou
Add new actions
bf7c9ee
@Shaobo-Zhou
Add new actions
6d2733f
@Shaobo-Zhou
Add tests for more coverage
468da2e
@Shaobo-Zhou
Update tests
737a9f2
@Shaobo-Zhou
Update override
94c25ab
@Shaobo-Zhou
Update comments
3ff922e 
Update
@Shaobo-Zhou
Update noxfile.py and CHANGELOG.md
782caf8
@Shaobo-Zhou
Clean up venv after each session to free up space
44e0e40
@Shaobo-Zhou
Clean up venv after each session to free up space
350bae5
@Shaobo-Zhou
Clean up venv after each session to free up space
91208d1
@Shaobo-Zhou
Clean up venv after each session to free up space
622d409
@Shaobo-Zhou
Update noxfile
fa008a6
@Shaobo-Zhou
Update ibm runtime dependency
0c98e56
@Shaobo-Zhou
Update noxfile
34a1c7c
@Shaobo-Zhou
Update noxfile
a8d069a
@Shaobo-Zhou
Update noxfile
114b79b
@Shaobo-Zhou
Fetch update from main
aaf14b1
@Shaobo-Zhou
Merge remote-tracking branch 'upstream/main' into new_structure
e39cd7e
@Shaobo-Zhou
Fix ruff checks
e7b4174
@Shaobo-Zhou
Update action space and add normalized gate counts as RL features
fcab4fa
@Shaobo-Zhou
Fix FOM comparison logic
cb4d0fb
@Shaobo-Zhou
Remove 3-qubit gates from dict
988a8f7
@Shaobo-Zhou
Add reward shaping
9a40b3e
@Shaobo-Zhou Shaobo-Zhou changed the title Add step-wise intermediate reward Add stepwise intermediate reward Nov 26, 2025
@Shaobo-Zhou Shaobo-Zhou changed the title Add stepwise intermediate reward Add stepwise intermediate reward for RL Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

❌ Patch coverage is 80.97166% with 47 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/mqt/predictor/rl/predictorenv.py 85.9% 25 Missing ⚠️
src/mqt/predictor/rl/cost_model.py 62.7% 22 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Shaobo-Zhou