-
Notifications
You must be signed in to change notification settings - Fork 22
✨ Switch to mqt-core
Python package
#432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e95ffd5
to
5495501
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
=======================================
+ Coverage 95.8% 96.1% +0.3%
=======================================
Files 39 40 +1
Lines 1837 1877 +40
Branches 225 224 -1
=======================================
+ Hits 1760 1804 +44
+ Misses 77 73 -4
|
96ff41e
to
db6cb20
Compare
055c342
to
bf94b85
Compare
77145ad
to
64dfa87
Compare
64dfa87
to
fcb3755
Compare
## Description This PR updates the CD workflow so that anytime it runs on a push to `main`, it uploads the resulting package to Test PyPI. This allows to battle test the packages before official releases. This will be especially important in the context of #432 ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines.
dca2e62
to
2645f59
Compare
Alright, some progress. The new The Ubuntu 22.04 builds fail because pybind decides that the compiled version of mqt-core that comes from PyPI is not binary-compatible with the mqt-qcec extension being compiled. |
2645f59
to
5d56d28
Compare
4acce1a
to
0df5561
Compare
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
(temporarily from a pre-release) Signed-off-by: burgholzer <[email protected]>
0df5561
to
12fc1d0
Compare
- 🍱 translate `.real` circuits to `.qasm` Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
12fc1d0
to
a8e5704
Compare
Signed-off-by: burgholzer <[email protected]>
A year-long odyssey is finally coming to an end. All the tests are green, all issues resolved. I see no reason for leaving this lying around anymore. Especially, since we cannot update to more recent versions of MQT Core without this PR. |
Description
This is an alternative to #355 and marks the final transition to the
mqt-core
Python package. See #355 and #352 for some history on this topic.In addition to directly using the MQT Core Python package, this PR makes Qiskit an optional dependency of MQT QCEC. All core functionality is now covered MQT-internally.
Checklist: