-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tuple generator #71
Conversation
79d5831
to
86d358d
Compare
I've replaced it with better implementation using nette/php-generator. It works ways better in my opinion. |
dc1e0ec
to
57a63fe
Compare
05a9088
to
b33c329
Compare
Todo:
|
f3fa3fe
to
0bffdb4
Compare
Ok, I belive I'm done. ~1300 lines of the PR is generated automatically, but it's still quite big, sorry for that 😄
I've added validation command to |
looks cool, are you happy to rebase and wait for php 8.2 upgarde? |
85518d2
to
97824b6
Compare
c67c442
to
33d4e4f
Compare
@@ -6,3 +6,5 @@ clover.xml | |||
.idea | |||
composer.lock | |||
/.phpunit.cache/ | |||
.tuple/* | |||
!.tuple/.gitkeep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not against it, but couldn't we use temp dir?
Hey @mtk3d, Is there anything left to do here, because I would like to give it a chance, it's a big PR and I think it would be a pity to leave it open :) |
Hi @mtk3d, ping again, If you don't have time right now, I can fix the changes after rebase and do a merge. |
Closes #38 |
Thanks @mtk3d 🍻 |
Hey @akondas sorry for not responding |
Hello 😄
I prepared my proposal of Tuples with generics, as discussed in here #38
It's just proposal, still in progress, there is no tests yet.
I started by just coding this classes manually, but making them manually without mistakes is hard, and laborious. So following vavr's approach, I built a template with command that generates the code of the Tuples.
I'm not 100% contented by this solution, but that's the fastest and lightest solution that came to my mind.
I'm also wondering about using library like https://github.com/nette/php-generator. I could install it as a dev dependency and use it to generating the code in object oriented way, and it could be more readable maybe 🤔
@akondas What do you think about that?