feat: a2a group extension#2
Open
msardara wants to merge 2 commits into
Open
Conversation
Signed-off-by: Mauro Sardara <msardara@cisco.com>
Signed-off-by: Mauro Sardara <msardara@cisco.com>
micpapal
reviewed
Oct 6, 2025
| message GroupUpdate { | ||
| // A unique ID assigned for this update. | ||
| string update_id = 1; | ||
|
|
Collaborator
There was a problem hiding this comment.
Here I think we need the sender_agent_id as in the GroupPublish
muscariello
reviewed
Oct 6, 2025
| // The wrapper message for a peer sending any type of update to the group. | ||
| message GroupPublish { | ||
| // A unique identifier for the conversation thread (the "group"). | ||
| string thread_id = 1; |
Owner
There was a problem hiding this comment.
definition of this id is missing and this is normative
muscariello
reviewed
Oct 6, 2025
|
|
||
| // Optional identification of the agent that this message is intended for. | ||
| // If empty, the message is intended for all agents in the group. | ||
| string target_agent_id = 6; |
Owner
There was a problem hiding this comment.
in this way it is either one or all: what about an array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.