Skip to content

Fix tuning plugin #28709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix tuning plugin #28709

wants to merge 1 commit into from

Conversation

XiaoMigros
Copy link
Contributor

@XiaoMigros XiaoMigros commented Jul 7, 2025

Resolves: #28573
Resolves: #25720

Old:

New:

I took the liberty of combining all the tuning plugins into one, since they all do the same thing. Hoping this plugin isn't plagued with as many crashes as Retrograde, since the score modifications are less complicated!
Additionally, the plugin now works for list selections, has a reset option, and stores all the tunings in settings, instead of single tunings to a file.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup
Copy link
Member

Someone else did something similar in #26257 😬
Hopefully both efforts can somehow be combined, but I fear that might be difficult...

@XiaoMigros
Copy link
Contributor Author

That's very unfortunate! I'll leave it to you to decide which PR you want to go with, but I'm sure some parts of either could be combined...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tuning plugin not working Preinstalled Tuning plugin does not annotate in 4.4
2 participants