Skip to content

Conversation

XiaoMigros
Copy link
Contributor

Resolves: #28419

Since #28957 it's easy to expose this to the API. Testing this a few months ago when std::list was used led to some unstable results, but now that it's an std::vector like the other plugin list properties I haven't encountered any issues.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@cbjeukendrup
Copy link
Member

The problem with children is that it returns all elements whose parent is this, but those are not necessarily actually part of the score (for example, they might be in the undo stack). So therefore I'm not sure whether we should expose it.

@XiaoMigros XiaoMigros marked this pull request as draft August 27, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Add a ‘children’ property to the Element object
2 participants