Skip to content

Conversation

juli27
Copy link
Contributor

@juli27 juli27 commented Aug 30, 2025

They used to be integers in the pre-3.0 days, where a staff or bar line could specify that it spans multiple staves. This then got simplified to a bool, but this transition wasn't done cleanly. This commit makes up for that by making sure that we only work with booleans. int values are converted appropriately when reading pre-3.0 scores.

This gets rid of all property type mismatch log messages related to span and barLineSpan.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@juli27 juli27 force-pushed the cleanupBarLineSpan branch 3 times, most recently from 3bdef8c to a9cd231 Compare September 1, 2025 16:03
@juli27 juli27 force-pushed the cleanupBarLineSpan branch from a9cd231 to b2f7b99 Compare September 9, 2025 16:40
Copy link
Member

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I thought I had already reviewed this, but apparently not. Better late than never!

They used to be integers in the pre-3.0 days, where a staff or bar line
could specify that it spans multiple staves. This then got simplified
to a bool, but this transition wasn't done cleanly. This commit makes up for
that by making sure that we only work with booleans. int values are
converted appropriately when reading pre-3.0 scores.
@cbjeukendrup cbjeukendrup merged commit eeee318 into musescore:master Sep 26, 2025
13 checks passed
@juli27 juli27 deleted the cleanupBarLineSpan branch September 26, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants