Skip to content

Conversation

XiaoMigros
Copy link
Contributor

@XiaoMigros XiaoMigros commented Aug 31, 2025

Resolves: #24922
Resolves: #26612

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@XiaoMigros XiaoMigros force-pushed the fix-naturals-keysig branch 15 times, most recently from cc3845f to 4622c48 Compare August 31, 2025 21:36
@its-not-nice its-not-nice self-requested a review September 1, 2025 05:04
@XiaoMigros XiaoMigros changed the title Fix #24922, 26612: Refactor naturals in key signatures Fix #24922, 26612: Refactor key signatures Sep 1, 2025
@XiaoMigros XiaoMigros force-pushed the fix-naturals-keysig branch 2 times, most recently from 611b124 to 8c14f71 Compare September 1, 2025 09:15
@XiaoMigros XiaoMigros marked this pull request as draft September 5, 2025 11:00
@XiaoMigros XiaoMigros force-pushed the fix-naturals-keysig branch 4 times, most recently from e576c01 to 8178388 Compare September 5, 2025 12:07
@XiaoMigros XiaoMigros force-pushed the fix-naturals-keysig branch 3 times, most recently from 0bd032a to 12d2ecc Compare September 5, 2025 12:56
@XiaoMigros XiaoMigros force-pushed the fix-naturals-keysig branch 2 times, most recently from bce2006 to a124cf3 Compare September 5, 2025 13:07
@XiaoMigros XiaoMigros marked this pull request as ready for review September 5, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unwanted naturals showing up in key signatures at the beginning of system Old style key signatures can't be placed at the head of a line
2 participants