More fret diagram improvements #29774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-spa
force-pushed
the
moreFretDiagramImprovements
branch
3 times, most recently
from
07498b9 to
c24167a
Compare
avvvvve
approved these changes
Sep 10, 2025
miiizen
reviewed
Sep 10, 2025
| void FretLinkHarmony::undo(EditData*) | ||
| { | ||
| if (m_unlink) { | ||
| m_fretDiagram->linkHarmony(m_harmony); |
There was a problem hiding this comment.
This function sets the harmony's z value and applies some alignment changes. I think we still need to do these things when adding and removing harmony from fret diagrams.
| if (m_unlink) { | ||
| m_fretDiagram->linkHarmony(m_harmony); | ||
| } else { | ||
| m_fretDiagram->unlinkHarmony(); |
miiizen
reviewed
Sep 10, 2025
| public: | ||
| FretLinkHarmony(FretDiagram*, Harmony*, bool unlink = false); | ||
|
|
||
| UNDO_TYPE(CommandType::FretLinkHarmony) |
There was a problem hiding this comment.
This enum value can be removed now
mike-spa
force-pushed
the
moreFretDiagramImprovements
branch
from
f395c0c to
aa95bd4
Compare
…plify code We can use Score::undoChangeParent instead of FretLinkHarmony
Simplify z-level management Remove unused unlinkHarmony Remove unused resetHarmonyAlignment Remove unused linkHarmony Remove unused applyAlignmentToHarmony Remove unused CommandType::FretLinkHarmony
mike-spa
force-pushed
the
moreFretDiagramImprovements
branch
from
aa95bd4 to
c37a121
Compare
miiizen
approved these changes
Sep 10, 2025
mike-spa
added a commit
to mike-spa/MuseScore
that referenced
this pull request
Sep 12, 2025
…vements More fret diagram improvements
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #29716
Resolves: #29009